dpogue opened a new pull request, #216:
URL: https://github.com/apache/cordova-common/pull/216

   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   We want a declarative way for a plugin to opt-in to using Package.swift for 
managing its code and resources as opposed to file copying with 
`source-file`/`header-file`/`resource-file`/etc.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Adds a helper method to detect if there is a `<platform name="ios" 
package="swift">` tag.
   
   Caveats:
   * This currently only looks at the first iOS platform declaration
   * This doesn't currently check the value of the `package` attribute. If it 
exists, we assume it is a Swift package. Ideally I'd love for this to be a 
boolean attribute like in HTML, but XML doesn't support those 😒 
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Added unit test case.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to