kumo01GitHub opened a new pull request, #286: URL: https://github.com/apache/cordova-plugin-geolocation/pull/286
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> workaround fix #285 According to [W3C](https://www.w3.org/TR/geolocation/#request-a-position), request a position and acquire a position should processing in parallel. In result, timeout timer starts before application gets permission request result. ### Description <!-- Describe your changes in detail --> Setup timer in JavaScript for Android. At first, I referenced iOS implementation but `createTimeout` didn't work as I thought. (When timeout, `timeoutTimer` in `getCurrentPosition` didn't be set null. This caused success callback and return current position after timeout error.) So, there is some deference. ### Testing <!-- Please describe in detail how you tested your changes. --> Tested with simulator and sample application. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
