breautek opened a new pull request, #308: URL: https://github.com/apache/cordova-plugin-media-capture/pull/308
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> This PR depends on https://github.com/apache/cordova-plugin-media-capture/pull/307 With the removal of Media Store queries, we do not need the READ/WRITE external storage permissions. ### Description <!-- Describe your changes in detail --> Removed several methods for managing permissions as they were not necessary. KEPT camera permission handling for that fringe case where it is required if it is declared in the manifest. Added GRANT WRITE flag to Video/Image intents, as that is necessary to give the third-party application write access to the specified directory (as provided by our File Provider). Audio must be handled differently. The `RECORD_SOUND_ACTION` intent does not make use of the `EXTRA_OUTPUT` parameter therefore we cannot instruct the third-party application to write to a location of our choice. Instead they will always write to external storage. For consistency however, we will copy the file to the cache directory. ### Testing <!-- Please describe in detail how you tested your changes. --> Ran Paramedic tests. Manual tests with and without the CAMERA permission declared on API 28 & 29. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
