dpogue opened a new pull request, #1520:
URL: https://github.com/apache/cordova-ios/pull/1520

   
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   
   ### Description
   <!-- Describe your changes in detail -->
   This ends up being less confusing for everyone because the resulting 
framework is named Cordova.framework and the header paths are all 
`<Cordova/*.h>` but currently you need to reference the Swift dependency as 
"CordovaLib" rather than "Cordova".
   
   As far as I can tell from a quick search of public Package.swift files on 
GitHub, nobody has actually consumed this as a Swift package, so any breakage 
should be minimal and we should take the opportunity to do this right as part 
of the major version bump.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Existing tests pass.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to