dpogue opened a new pull request, #1521:
URL: https://github.com/apache/cordova-ios/pull/1521

   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   CDVPlugin's commandDelegate is a weak pointer, which means technically in 
Swift it should be an optional type that requires unwrapping. For some reason, 
it is not.
   
   If the wrap the CDVPlugin class in the `ASSUME_NONNULL` macro, Swift 
suddenly starts enforcing that it's an optional, and this breaks all existing 
Swift plugins.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   You aren't allowed to combine `weak` and `nonnull`, and all the properties 
in CDVPlugin are weak, so just... don't wrap it in `ASSUME_NONNULL` to make 
life easier for everyone 🙃
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Tested with mobilespec (which fails on master and passes with this change)
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to