erisu opened a new pull request, #1817:
URL: https://github.com/apache/cordova-android/pull/1817

   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   - Support previous non-E2E design in SDK 35+ (including SDK 36)
   - Support Night & Day Theme as Default
     - Splash Screen also follow Night & Day setting unless color defined.
   - Add an platform internal plugin called SystemBarPlugin
     - Statusbar (Include auto changing of font/icon color)
     - Nav/Gesture Bar
   - Add Core StatusBar JS APIs
   
   ### Description
   <!-- Describe your changes in detail -->
   
   **StatusBar JS API:**
   
   - `window.statusbar.visible = <true|false>`
   - `window.statusbar.setBackgroundColor('#AARRGGBB')`
   
   **`config.xml preferences:**
   
   This PR reuses all of the previous preferences. Order of imports listed below
   
   - For **StatusBar**
     - `StatusBarBackgroundColor`
     - `BackgroundColor`
   - For **Nav/Gesture Bar**
     - `BackgroundColor`
   - For **Splash Screen**
     - `AndroidWindowSplashScreenBackground`
     - `SplashScreenBackgroundColor`
     - `BackgroundColor`
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   - `npm t`
   - Build testing
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to