breautek commented on code in PR #1819: URL: https://github.com/apache/cordova-android/pull/1819#discussion_r2185553061
########## lib/builders/ProjectBuilder.js: ########## @@ -205,7 +205,8 @@ class ProjectBuilder { '// GENERATED FILE - DO NOT EDIT\n' + 'apply from: "cdv-gradle-name.gradle"\n' + 'include ":"\n' + - settingsGradlePaths.join('')); + settingsGradlePaths.join('') + + '\nif (file("settings-additional.gradle").exists()) { apply from: "settings-additional.gradle" }\n'); Review Comment: we have a concept of `build-extras.gradle` which is virtually the same thing but for the build.gradle file. So I'm thinking to keep naming consist we should actually look for `settings-extra.gradle` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org