erisu opened a new pull request, #1426:
URL: https://github.com/apache/cordova-docs/pull/1426

   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   https://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Closes #904
   Resolves #884
   Closes #875
   
   While Cordova primarily focuses on apps created through the CLI rather than 
platform-centric workflows, I wanted to modernize this guide to serve as a more 
up-to-date starting point for those looking to embed Cordova manually.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   1. Removed the distribution download step. Not needed in this guide.
   2. Removed the follow first Cordova app step. Not related to embedding.
   3. Removed the "Copy Cordova framework files" step. Not needed in this guide.
   4. Removed `ant` related content. Outdated content
   5. Added the step in how to how Cordova-Android framework with `build.gradle`
       - Covers Groovy DSL & Kotlin DSL syntax
   6. Added Kotlin & Java example for `TestActivity`
   7. Talked about theming requirement. 
       - E.g. Since SplashScreen API was baked in the `CordovaActivity`, the 
Activity should point to the SplashScreen theme
       - Also `postSplashScreenTheme` should inherit from a `Theme.AppCompat.*` 
style/
   8. Added Jetpack Compose Example (Kotlin only) 
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   Tried to build an app following the steps.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to