erisu opened a new pull request, #53:
URL: https://github.com/apache/cordova-eslint/pull/53
It looks like we forgot to revisit and confirm the Node.js version
requirement after upgrading to ESLint 9.
Below is an example of what happens when attempting to run `npm i` with
Node.js `v20.5.0`. The actual output would include additional ESLint-related
packages as well:
```log
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'eslint@9.31.0',
npm WARN EBADENGINE required: { node: '^18.18.0 || ^20.9.0 || >=21.1.0' },
npm WARN EBADENGINE current: { node: 'v20.5.0', npm: '9.8.0' }
npm WARN EBADENGINE }
```
Previously, we updated the minimum Node.js version to `>=20.5.0` across the
board. At that time, we verified this requirement by checking
`package-lock.json` files in various repos (e.g., `cordova-ios`) and confirmed
that `>=20.5.0` would be appropriate. However, ESLint 9 was not yet included in
our dependencies at that point.
It should now be safe to raise our minimum Node.js version to `>=20.9.0`,
since no packages (aside from the Cordova-iOS 8 beta) have been officially
released with the 20.x requirement set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
