dpogue opened a new pull request, #237:
URL: https://github.com/apache/cordova-common/pull/237

   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   The strip-bom npm package moved to mandatory ES Modules, which means we're 
stuck on an old version and it shows up every time we run `npm outdated` as 
something to be checked. The actual code for stripping the BOM is a handful of 
lines of code that a stable and well-solved problem, so it should be fine to 
just bring this one function into cordova-common as a util rather than 
depending on a 3rd party module to provide it.
   
   In a better world, there would be some built-in NodeJS option to handle 
this...
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   All existing tests pass
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to