erisu opened a new pull request, #239: URL: https://github.com/apache/cordova-common/pull/239
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected All ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Resolves #213 ### Description <!-- Describe your changes in detail --> This breaking change wil change the behavior of `<resource-file>`. `<resource-file>`, as its named, only supported copying individual files. As far as I am aware, this is how it has always been documented and described. This PR basically change the understanding of how `resource-file` works. It will now include copying of `directories` and all of its inner content recursively. This PR will only deal with the recursive copy of directories. Platforms might need to improve its own logic to determine how it should handle what is copied over. For example Cordova-iOS would have added each resource file to the pbxproj as resource. With this change, it wont add all files and folders to the pbxproj as resources and it might not add what you expect, depending on how the `resource-file` is used. ### Testing <!-- Please describe in detail how you tested your changes. --> - `npm t` - Simple build test. Added to `config.xml` ``` <resource-file src="res/Test" target="../Test" /> ``` Created directory `res/Test` with contents: ``` res/Test ├── Test1.md └── Test2 └── Test2.md ``` ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
