erisu commented on PR #1100: URL: https://github.com/apache/cordova-ios/pull/1100#issuecomment-3195526972
@ath0mas Sorry this took a bit longer to review and merge — I'd like to move things forward and get this PR ready. How would you prefer to proceed? 1. Rebase this existing PR 2. Open a new PR yourself 3. Or have me create a new PR instead Here are the changes I'd recommend: * Update the package id/name to: `org.apache.cordova.hellocordova` Even though this is just a template (and we expect developers to set their own package ID), this one feels more accurate to the Apache Cordova project. While there is a `cordova.io` domain, it isn't officially under Apache. Regarding the `hellocordova` vs `helloCordova` casing — I'd suggest going with lowercase. This follows the convention used for Java packages and iOS app identifiers. For references, I also submitted related PRs to `cordova-android` and `cordova-app-hello-world` to align with these changes: * https://github.com/apache/cordova-android/pull/1837 * https://github.com/apache/cordova-app-hello-world/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
