GitToTheHub commented on PR #191: URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3397688146
> Nope, it's not obsolete. It controls some checks on the Cordova CLI, and/or platforms when installing cordova plugins. Why does the [documentation](https://cordova.apache.org/docs/en/12.x-2025.01/plugin_ref/spec.html#engines-and-engine).) say for the `plugin.xml` `engines` tag: > NOTE: In Cordova 6.1.0+, the recommended place to specify platform, plugin, and CLI dependencies is in a plugin's package.json. See [specifying Cordova dependencies](https://cordova.apache.org/docs/en/12.x-2025.01/guide/hybrid/plugins/index.html#specifying-cordova-dependencies) for more information This sounds for me as the tag is obsolete and should be replaced by `engines` in package.json. Also the documentation says in [Specifying Cordova Dependencies](https://cordova.apache.org/docs/en/12.x-2025.01/guide/hybrid/plugins/index.html#specifying-cordova-dependencies): > This feature is intended to eventually replace the [engines element](https://cordova.apache.org/docs/en/12.x-2025.01/plugin_ref/spec.html#engines-and-engine) in plugin.xml. There it says, it will replaces the `engines` tag in `plugin.xml`. Why do plugins work, if I remove the `engines` tag? > In this case, it's set to CLI requirement >100 (which doesn't exist) on v4 of this plugin (which also doesn't currently exist). The rationale is that it forces whoever does a major version bump to also pay attention to the engines block and to set it accordingly. I don't have any words .. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
