GitToTheHub commented on PR #1780: URL: https://github.com/apache/cordova-android/pull/1780#issuecomment-3449937158
Hi @erisu, I was marking this pr before as "faulty" because I thought I mixed something up. But when I researched the Code to document the deprecated `CordovaPlugin.onRequestPermissionResult` and the new one `CordovaPlugin.onRequestPermissionsResult`, I saw, that the new one is never called by `CordovaActivity`. It would only be called by `PermissionHelper`, but this class nowhere used in the code. So the following things are to clear: - I would add a call to the new `CordovaPlugin.onRequestPermissionsResult`, where the old one was called. So both are called. - Rename `CordovaInterfaceImpl.onRequestPermissionResult` to `CordovaInterfaceImpl.onRequestPermissionsResult` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
