breautek commented on PR #573: URL: https://github.com/apache/cordova/pull/573#issuecomment-3582234763
> > When you're on the “Files changed” tab reviewing the changes, there's a toggle above the file content that lets you switch between "Display the source diff" and "Display the rich diff". > > Click "Display the rich diff" to render the Markdown page. That will allow you to see the graph. > > I know, but I thought @breautek was asking, how a screenshot is made with Mermaid. Mermaid renders a live diagram which is not a screenshot, i didn't found a function to export it as an image. I was just looking for a screen snippet -- but I forgot that github does do rendered markdown diffs so that works too. I see the value of using mermaid, it's always nice to remove requirements of third-party tools. As far as style goes, I don't think it's too bad. I do think old sketchviz tool looks a bit better but not better enough to keep using sketchviz. This is subjective of course. On more of a practical note... if we want to render this outside of github (such as the docs site), I wonder if that will pose a problem. The docs site is powered by jekyll and it might require adding in a dependency to support mermaid rendering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
