dpogue commented on PR #937: URL: https://github.com/apache/cordova-plugin-camera/pull/937#issuecomment-3620988635
This plugin says it supports cordova-ios >=5.1.0 which means it needs to support building with Xcode 10, which means the code needs to compile even when the `PHPickerViewController` classes do not exist in the SDK. That's why everything that uses it needs to be wrapped in a `#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 140000` check. `API_AVAILABLE(ios(14))` is sufficient for a newer SDK targeting an older device, but not for an older SDK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
