serhiikh-gk commented on PR #1094:
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/1094#issuecomment-3660724178

   > > it keeps only last instance alive/active and you can't communicate 
anymore with older instances
   > 
   > If that's the case, then we can probably update the native side to retain 
references of IAB instances, and assign them IDs so that we can map calls back 
onto them.
   
   basically it is what was done with CDVInAppBrowserWindowManager (ios) / 
InAppBrowserWindowManager (android). To hold the instances, assign unique 
windowId, and send events to correct browser instance.
   
   Seems like there were also issues reported + some discussions on 
stackoverflow:
   https://github.com/apache/cordova-plugin-inappbrowser/issues/533
   https://github.com/apache/cordova-plugin-inappbrowser/issues/617
   https://github.com/apache/cordova-plugin-inappbrowser/issues/752
   https://github.com/apache/cordova-plugin-inappbrowser/issues/937
   
   Let me first harmonise InAppBrowser and InAppBrowserMulti or prove that they 
should stay separate + make unit test to work via cordova-paramedic or remove 
them. And I'll back to MR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to