breautek commented on code in PR #1097:
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/1097#discussion_r2635823985
##########
src/ios/CDVWKInAppBrowser.m:
##########
@@ -765,6 +765,11 @@ - (void)createViews
self.closeButton = [[UIBarButtonItem alloc]
initWithBarButtonSystemItem:UIBarButtonSystemItemDone target:self
action:@selector(close)];
self.closeButton.enabled = YES;
+
+ // Fixes the Liquid Glass issue on iOS version >= 26 where the buttons
have a translucent background
+ if (@available(iOS 26.0, *)) {
Review Comment:
I don't believe these checks are sufficient as it assumes that the
environment is running at least XCode 26 and Cordova iOS framework declares
support for XCode 15 and later.
There is a way to do a preprocessor check that is more resilient to the
XCode environment, I just don't recall the exact syntax for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
