erisu commented on code in PR #1597: URL: https://github.com/apache/cordova-ios/pull/1597#discussion_r2646054798
########## .gitignore: ########## @@ -30,3 +30,6 @@ coverage/ npm-debug.log .nyc_output/ **/www/cordova.js + +# Swift Package Manager (SPM) build artifacts +.build/ Review Comment: We usually keep new line at the end of every file. This PR removed it and I was only pointing it out. https://github.com/apache/cordova-ios/commit/32e5389c6141dbde11b4c3bcee5f6e67eaa2f057 There are some cases where a new line at the end of the file is not possible but in most cases we try to keep it. I will fix it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
