breautek commented on PR #937: URL: https://github.com/apache/cordova-plugin-camera/pull/937#issuecomment-3738782460
> Did I understand correctly that a PR always needs approval from another PCM? It's a good rule to follow when possible, but isn't strictly necessary. However I would always announce a last-call unilaterally pushing a PR through. I'd also say it can depend on the PR as well. In this case you already have a +1 from another PMC member, so this isn't a unilateral merge, should you merge. iOS 14/15 tests are failing due to their desired xcode versions are no longer available it appears. iOS 17 does passes. I think that maybe calls for a CI workflow update, which can be done in anther PR and once merged this PR can be rebased. But I won't really consider this a blocker if you're confident in the code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
