GitToTheHub commented on code in PR #1463:
URL: https://github.com/apache/cordova-docs/pull/1463#discussion_r2698745171
##########
www/_includes/toc_recursive_dropdown.html:
##########
@@ -1,7 +1,10 @@
{% for entry in include.entries %}
+{% assign normalized_my_entry = include.my_entry | remove: '/' %}
+{% assign normalized_entry_url = entry.url | remove: '/' %}
Review Comment:
Since this is used only to determine if the entry should be highlighted, you
could make a variable like
```liquid
{% assign entry_active = include.my_entry | remove: '/' == entry.url |
remove: '/' %}
```
and use it for highlighting.
##########
www/_includes/toc_recursive_main.html:
##########
@@ -1,24 +1,29 @@
<ul class="site-toc">
{% for entry in include.entries %}
+ {% assign normalized_my_entry = include.my_entry | remove: '/' %}
+ {% assign normalized_entry_url = entry.url | remove: '/' %}
Review Comment:
Since this is used only to determine if the entry should be highlighted, you
could make a variable like
```liquid
{% assign entry_active = include.my_entry | remove: '/' == entry.url |
remove: '/' %}
```
and use it for highlighting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
