GitToTheHub commented on PR #942: URL: https://github.com/apache/cordova-plugin-camera/pull/942#issuecomment-3774870622
> There are lots of little reformatting changes around uses of `CDVPluginResult` here that make the diff a bit noisy. It would be better to avoid making formatting changes to unrelated code in the same commit as behaviour changes. Ok, I will pay attention to that in the future. > On a larger note, is there a reason that we treat image and video files differently? I've never used the camera plugin, but I assume you want the file data for the picked file in both cases, right? This is correct, in both cases an image or video should be picked. This plugin does some processing on the image like correct orientation, scaling, which is not done on the video. In the end, the image is also copied to a temporary location. So this is the same for both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
