dpogue opened a new pull request, #247:
URL: https://github.com/apache/cordova-common/pull/247

   ### Platforms affected
   All
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   The `@netflix/nerror` package doesn't seem to be actively maintained, and it 
has `lodash` as a dependency which is a big source of dependabot security 
warnings.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Implement our own CordovaError mimicking the (few) relevant parts of VError.
   
   There are technically a few breaking changes here, to be discussed:
   * I changed the `err.cause()` method to an `err.cause` getter
     * This was used in 1 spot in the tests
   * I changed the `err.info()` method to an `err.info` getter (unused)
   * I did not implement the `err.assignInfo(...)` method (unused)
   * Several class-level methods are not implemented because they were not used:
     * `assignInfo`
     * `findCauseByName`
     * `hasCauseWithName`
     * `errorFromList`
     * `errorForEach`
     * `isVError`
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Existing tests pass and added test cases to ensure proper code coverage.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to