dpogue commented on code in PR #944:
URL:
https://github.com/apache/cordova-plugin-camera/pull/944#discussion_r2742704177
##########
src/ios/CDVCamera.m:
##########
@@ -298,6 +298,8 @@ - (void)showPHPicker:(NSString*)callbackId
withOptions:(CDVPictureOptions*)pictu
{
// PHPicker must be created and presented on the main thread.
dispatch_async(dispatch_get_main_queue(), ^{
+ // Using just [PHPickerConfiguration init] is more flexible and lets
the picker return items
+ // that aren’t PHAssets (e.g., cloud/shared providers), but it will
not return asset identifiers.
Review Comment:
Is this comment necessary? `Using just [PHPickerConfiguration init] is more
flexible` as opposed to what? More flexible compared to what?
`[[ClassName alloc] init]` is the standard pattern for initializing an
instance, so I would never *expect* to see anything different here, and it
seems weird to have a comment saying "This is better and more flexible"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
