kumo01GitHub commented on code in PR #1112:
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/1112#discussion_r2783008156
##########
src/ios/CDVWKInAppBrowser.m:
##########
@@ -483,6 +498,15 @@ - (void)webView:(WKWebView *)theWebView
decidePolicyForNavigationAction:(WKNavig
if ([allowedSchemes containsObject:[url scheme]]) {
[theWebView stopLoading];
[self openInSystem:url];
+ shouldStart = NO;
+ } else if ((self.callbackId != nil) && ![[ url scheme]
isEqualToString:@"http"] && ![[ url scheme] isEqualToString:@"https"] && [self
isAllowedScheme:[url scheme]]) {
Review Comment:
> - Add documentation to the condition, what's happening here
I added comment and clarify the condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
