GitToTheHub opened a new pull request, #1122: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1122
- Initializing the done button as system item with `initWithBarButtonSystemItem`, will give contraints warnings in iOS 26, saying `Unable to simultaneously satisfy constraints.`. This is because the toolbar width is 0 when the bar button is added. When using `initWithTitle` this gives no warnings. - Simplified method `setCloseButtonTitle`: The closeButton has not to be reinitialized anymore, since we already used `initWithTitle` for initializing the bar button. title and tintColor can be set directly. The item must not be replaced in the toolbar. - The button will be more similar to iOS 18 where also `Done` was shown in the button. On iOS 26 a check mark was shown. - As a drawback, the `Done` button is not internationalized any more, but can be set by the option `closebuttoncaption` - This only fixes contraints errors in iOS 26 | Before | After | | --- | --- | | <img width="167" height="119" alt="image" src="https://github.com/user-attachments/assets/a46f964e-edfa-4efe-8341-0d95a1bbca44"; /> | <img width="188" height="127" alt="Bildschirmfoto 2026-02-20 um 21 55 07" src="https://github.com/user-attachments/assets/6ae8c98b-33f7-464a-9d40-7d64c0b49861"; /> | <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes in detail --> ### Testing <!-- Please describe in detail how you tested your changes. --> ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
