erisu commented on PR #1901: URL: https://github.com/apache/cordova-android/pull/1901#issuecomment-4046634219
This is just my opinion, but I feel this might work better as a plugin rather than something included directly in the core library. I understand the concern where users might use modern JavaScript that may not be supported in older WebViews, and that users should be made aware of this. But, I would be interested in hearing what others think about where this should reside. For example, what if people begin asking for the ability to custom design the dialog so it could match their app's design? Or add various buttons that might do a certain function in those scenarios. I'm curious how large this could become to support and maintain within the core library. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
