BigBalli commented on PR #694: URL: https://github.com/apache/cordova-cli/pull/694#issuecomment-4181227619
Good catch — you're right. Removed the `process.exit()` call from `bin/cordova`. The `process.exitCode` assignment there is already correct and sufficient. The actual fix for the reported issue is the `unhandledRejection` handler in `src/cli.js` — that catches rejected promises that never reach the `.catch()` in `bin/cordova`. `process.exit(1)` is appropriate there since it's a last-resort crash handler (same pattern as the existing `uncaughtException` handler right above it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
