breautek commented on issue #1913:
URL:
https://github.com/apache/cordova-android/issues/1913#issuecomment-4202149979
sounds like something that we can do in a patch but not sure if the proposed
solution is sufficient.
> The fix is straightforward — check if the activity name is already fully
qualified and use / instead of /.:
const activityName = manifest.getActivity().getName();
const launchName = activityName.includes('.')
? pkgName + '/' + activityName
: pkgName + '/.' + activityName;
The original assumption here is that the activity name will be the class
name, whose class resides in the root package namespace of the project.
So if we allow fully qualified package name to be used, we could probably
also allow a sub-package path to be used as well relatively in which case it
will have a `.` in the string. So using `includes('.')` could lead to false
positives where it should still be using the relative notation.
So I believe the more proper fix would be to test if the activity name
starts with the same string as the package name, and if so I think we can
conclude that the activity name is a fully qualified path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
