erisu opened a new pull request, #155: URL: https://github.com/apache/cordova-browser/pull/155
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected n/a ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Refactor & Cleanup ### Description <!-- Describe your changes in detail --> - Use arrow functions where possible - Use template literals where possible - Refactor `selfEvents` to `events` to remove the need of renaming the variable. - Cleanup require block and ordering - Remove unnecessary node shebang from files that not executable. - Add static method `version` to match with other platforms - Don't allow changing platform name when constructing new Api. - Add async to methods where needed - Converted `Api` to an ES6 class - Moved all static and non static Api methods to class - Converted prefixed `_*` methods to be private with `#*` ### Testing <!-- Please describe in detail how you tested your changes. --> - `npm t` - `cordova platform add` - `cordova run` ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
