breautek commented on code in PR #153:
URL:
https://github.com/apache/cordova-node-xcode/pull/153#discussion_r3183385369
##########
lib/pbxProject.js:
##########
@@ -89,7 +88,7 @@ pbxProject.prototype.allUuids = function() {
}
pbxProject.prototype.generateUuid = function() {
- var id = uuid.v4()
+ var id = require('crypto').randomUUID()
Review Comment:
can you hoist the `crypto` require up with the other requires?
`generateUuid` is something that I believe is triggered often and while
modules are cached and executed once for the first require, hoisting an access
variable just allows it to skip the cache-lookup each time this function is
invoked.
##########
package.json:
##########
@@ -7,11 +7,10 @@
"repository": "github:apache/cordova-node-xcode",
"bugs": "https://github.com/apache/cordova-node-xcode/issues";,
"engines": {
- "node": ">=10.0.0"
+ "node": ">=14.17.0"
Review Comment:
Can you revert this change back to `>=10.0.0`
I know this change requires 14.17.0 but that change should be in it's own PR
so that the engine bump can be independent of the UUID change -- should we find
a reason to revert the UUID change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
