GitToTheHub opened a new pull request, #1146: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1146
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected - Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> - On Android, when beforeload=yes was enabled, the beforeload event would only fire on the initial page load, then stop firing for subsequent navigations. - Added onCreateWindow override in InAppChromeClient to route popup navigations through InAppBrowserClient.shouldOverrideUrlLoading() instead of direct loadUrl() - Filter out transient URLs like about:blank to avoid state corruption - Re-enable waitForBeforeload in onPageFinished() so subsequent user navigations trigger beforeload again - Re-enable waitForBeforeload in onReceivedError() to ensure beforeload works even after load errors - Generated-By: GPT-5.3-Codex ### Description <!-- Describe your changes in detail --> ### Testing <!-- Please describe in detail how you tested your changes. --> ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
