GitToTheHub commented on PR #1023: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1023#issuecomment-4398955299
@dpogue @breautek @erisu The zoom controls can now be configured separately by this PR and Google recommends to disable them, since they are deprecated since Android 8. The default for this plugin was before, that they are enabled. Should this PR disable them by default? Would this be a breaking change, or this still ok for a minor update? The deprecation and recommended setting is documented on [WebSettings.setDisplayZoomControls](https://developer.android.com/reference/android/webkit/WebSettings#setDisplayZoomControls(boolean)). I think it's the right way to disable them by default since Google recommends it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
