GitToTheHub opened a new pull request, #1150: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1150
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected - Android - iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> - Fixes #521: Cookies were persisting despite clearcache/clearsessioncache options because navigation started before async clearing operations finished, causing a race condition. - Generated-By: GPT-5.3-Codex #### Android (src/android/InAppBrowser.java) - Extract cookie clearing into async clearCookies() method - Use modern async APIs (removeAllCookies/removeSessionCookies with callbacks) - Drop legacy pre-API 22 fallbacks (minimum supported is Android 5.1, API 22) - Defer inAppWebView.loadUrl() until cookie clearing callback completes - Add documentation explaining the async sequencing requirement #### iOS (src/ios/CDVWKInAppBrowser.m) - Refactor clearing logic into two focused methods: - clearData: removes all website data (cookies, localStorage, IndexedDB, cache) - clearCookie(sessionOnly): removes all or session-only cookies - Implement option precedence in clearWebsiteDataByOptions: 1. cleardata (covers all, including cookies) 2. clearcache (all cookies) 3. clearsessioncache (session cookies only) 4. no option (skip clearing) - Defer navigateTo/show until clearing completion callbacks fire - Add comprehensive inline documentation for flow and async operations ### Description <!-- Describe your changes in detail --> ### Testing <!-- Please describe in detail how you tested your changes. --> ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
