GitToTheHub opened a new pull request, #102: URL: https://github.com/apache/cordova-app-hello-world/pull/102
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected - All ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> - Before it was hard to add something when to test something. - The layout was broken on landscape - There were zoom and scroll issues with the template before - Added `user-scalable=no, maximum-scale=1, minimum-scale=1` so the app is not zoomable. Document the meta viewport attributes. Before the content was zoomed, when an input was clicked. - Improve documentation of Content Security Policy and format the content for readablility - Document CSS declarations - CSS: Changed height:100vh to min-height: 100vh, because the bottom safe area was otherwise not respected on iOS - Remove <meta name="msapplication-tap-highlight" content="no"> which was used Windows Phone (Internet Explorer) which is not supported anymore - Removed fade animation for device ready - Use modern JavaScript: Template litereals and const | master | PR | | --- | --- | | <img width="350" src="https://github.com/user-attachments/assets/f493e493-9732-4b5c-886f-a1efcd4a84cb"; /> | <img width="350" src="https://github.com/user-attachments/assets/a32bc002-8e3d-450d-8bb8-a1cb9b32703e"; /> | ### Description <!-- Describe your changes in detail --> ### Testing <!-- Please describe in detail how you tested your changes. --> ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
