gabriel2mm commented on code in PR #1924:
URL: https://github.com/apache/cordova-android/pull/1924#discussion_r3249219893
##########
framework/src/org/apache/cordova/CordovaActivity.java:
##########
@@ -222,16 +222,24 @@ protected void createViews() {
Insets bars = insets.getInsets(
WindowInsetsCompat.Type.systemBars() |
WindowInsetsCompat.Type.displayCutout()
);
+ Insets ime = insets.getInsets(WindowInsetsCompat.Type.ime());
boolean isStatusBarVisible = statusBarView.getVisibility() !=
View.GONE;
int top = isStatusBarVisible && !canEdgeToEdge && !isFullScreen ?
bars.top : 0;
- int bottom = !canEdgeToEdge && !isFullScreen ? bars.bottom : 0;
int left = !canEdgeToEdge && !isFullScreen ? bars.left : 0;
int right = !canEdgeToEdge && !isFullScreen ? bars.right : 0;
+ int bottom = 0;
+ if (!isFullScreen) {
+ bottom = !canEdgeToEdge ? Math.max(bars.bottom, ime.bottom) :
ime.bottom;
+ }
+
FrameLayout.LayoutParams webViewParams =
(FrameLayout.LayoutParams) webView.getLayoutParams();
- webViewParams.setMargins(left, top, right, bottom);
- webView.setLayoutParams(webViewParams);
+ if (webViewParams.leftMargin != left || webViewParams.topMargin !=
top
Review Comment:
I've added the inline documentation.
I believe we should avoid updating the WebView if the margin parameters
haven't changed. Re-applying the exact same parameters triggers redundant
layout passes, which can cause unwanted behaviors like infinite layout loops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
