GitToTheHub commented on PR #1925: URL: https://github.com/apache/cordova-android/pull/1925#issuecomment-4466901159
I looked through the search results and `cordova-plugin-camera` is one of the first search results which uses the `PermissionHelper`. The next one is `cordova-plugin-audioinput` which is actively maintained. The fix would be straightforward. The plugin calls instead of `PermissionHelper.hasPermission` just `cordova.hasPermission`. The same for `PermissionHelper.requestPermission` it would call `cordova.requestPermission` and for `PermissionHelper.requestPermissions` it would call `cordova.requestPermissions`. The right way would be to call the methods directly on `CordovaInterface` of the `CordovaPlugin` instead calling `PermissionHelper` which forwards the calls to it. How would you do the transitioning? Would it be the right approach to leave everything like it is, though it is not necessary? The minimum would be to inform plugin authors to change the way of calling it. A deprecation notice would be a first good way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
