GitToTheHub commented on PR #1924:
URL: https://github.com/apache/cordova-android/pull/1924#issuecomment-4467680106

   @gabriel2mm Thanks for the changes.
   
   @erisu Are you ok with using nested ternary operators here for calculating 
the bottom variable?:
   
   ```java
   int bottom = isFullScreen ? 0 : canEdgeToEdge ? imeInsets.bottom : 
Math.max(bars.bottom, imeInsets.bottom);
   ```
   
   Or do you prefer it with an outer condition?:
   
   ```java
   int bottom = 0;
   if (!isFullScreen) {
       bottom = canEdgeToEdge ? imeInsets.bottom : Math.max(bars.bottom, 
imeInsets.bottom);
   }
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to