dpogue opened a new issue, #1660:
URL: https://github.com/apache/cordova-ios/issues/1660

   # Bug Report
   
   ## Problem
   
   ### What is expected to happen?
   An availability macro should be defined for each Cordova iOS version so that 
plugins can check was version of Cordova they are being compiled against using 
the `CORDOVA_MIN_VERSION_REQUIRED` macro.
   
   
   ### What does actually happen?
   There is no macro defined for version 8.1.0 (`__CORDOVA_8_1_0`) despite new 
API being introduced that plugins might want to conditionally adopt.
   
   
   ### Command or Code
   <!-- What command or code is needed to reproduce the problem? -->
   
   The following plugin code will fail to compile against Cordova iOS 8.1.0 
because it cannot detect that the symbol is already defined, despite taking all 
the appropriate measures to only define it on older versions.
   
   ```objc
   // Define this notification name if we're on an older Cordova version
   #if defined(__CORDOVA_8_1_0) && CORDOVA_VERSION_MIN_REQUIRED < 
__CORDOVA_8_1_0
   const NSNotificationName CDVPluginContinueUserActivityNotification = 
@"CDVPluginContinueUserActivityNotification"
   #endif
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to