dpogue commented on code in PR #1661:
URL: https://github.com/apache/cordova-ios/pull/1661#discussion_r3346779368
##########
CordovaLib/Classes/Private/Plugins/CDVStatusBarInternal/CDVStatusBarInternal.m:
##########
@@ -37,8 +37,9 @@ - (void)setBackgroundColor:(CDVInvokedUrlCommand *)command
NSInteger valueR = [[command argumentAtIndex:0 withDefault:@0]
integerValue];
NSInteger valueG = [[command argumentAtIndex:1 withDefault:@0]
integerValue];
NSInteger valueB = [[command argumentAtIndex:2 withDefault:@0]
integerValue];
+ NSInteger valueA = [[command argumentAtIndex:3 withDefault:@255]
integerValue];
Review Comment:
The `#AARRGGBB` format is Android-specific, so that's not what we should be
trying to do in a web context.
It looks like there are issues with the Android side of the colour parsing
for the status bar, I'll try to get a PR up there to make it all consistent
later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
