breautek commented on PR #1950: URL: https://github.com/apache/cordova-android/pull/1950#issuecomment-4622466104
v12 is completely EOL so we won't be making any patches or releases -- for that reason alone I'm going to close this PR. Google Play requires targeting relatively recent SDK targets that these older platform versions isn't tested or usually does not support without breaking changes. We would advise you to upgrade as soon as it's feasible. But also, a simple search in the file shows that none of those imports are actually found or used in 12.x version, although they are used (with the necessary imports) in master. So I don't understand how `SystemWebChromeClient` could be causing import failures on those classes if they don't use them. I see (all 3) of the added imports are in fact used in current master and they have the appropriate imports already. If you don't distribute to Google Play or are otherwise not affected by Google's terms then you may maintain a copy of v12 with your own patches within the terms of the Apache license. Cordova CLI supports installing platforms directly from github: `cordova platform add https://github.com/denusklo/cordova-android.git#12.0.x` for example would install this PR branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
