dpogue opened a new pull request, #1664: URL: https://github.com/apache/cordova-ios/pull/1664
### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> We've had a mechanism for a while where if the ViewController is a WKScriptMessageHandler then it will be registered as the handler for Cordova actions rather than the default plugin implementation. Except there was a bug where it would try to register both of them with the same name and fail. ### Description <!-- Describe your changes in detail --> This checks if the ViewController is a candidate first, and only registers the plugin as the script handler if it is not. Also add a unit test case to ensure that a ViewController that implements the WKScriptMessageHandler protocol correctly receives the script messages. ### Testing <!-- Please describe in detail how you tested your changes. --> ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
