erisu commented on code in PR #167:
URL:
https://github.com/apache/cordova-node-xcode/pull/167#discussion_r3410989906
##########
lib/parser/pbxproj.js:
##########
@@ -178,9 +178,47 @@ function peg$parse(input, options) {
peg$c6 = function() { return Object.create(null) },
peg$c7 = function(list) {
var returnObject = list[0][0];
- for(var i = 1; i < list.length; i++){
+
+ for (var i = 1; i < list.length; i++) {
Review Comment:
I think a traditional `for` loop makes more sense here.
Since this is a parser for an Xcode project file and could potentially be
processing a large dataset, I'd prefer to keep it optimized for performance.
While V8 has improved `for...of` quite a bit, a standard `for` loop is still
generally the safest choice from a performance perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
