GitToTheHub commented on code in PR #1951: URL: https://github.com/apache/cordova-android/pull/1951#discussion_r3419625052
########## framework/src/org/apache/cordova/engine/SystemWebChromeClient.java: ########## Review Comment: Since we found out, that this method is not used anymore since API 19 (Android 4.4) and the HTML5 quota system is used instead, this could be added to the documentation of the method. Link to Android documentation of this method: https://developer.android.com/reference/android/webkit/WebChromeClient#onExceededDatabaseQuota(java.lang.String,%20java.lang.String,%20long,%20long,%20long,%20android.webkit.WebStorage.QuotaUpdater) Example: ```javadoc /** * Handle database quota exceeded notification. * This method is no longer called since API 19 (Androd 4.4). * The HTML5 quota system is used instead. * The method can be removed in a future release. * @see https://developer.android.com/reference/android/webkit/WebChromeClient#onExceededDatabaseQuota(java.lang.String,%20java.lang.String,%20long,%20long,%20long,%20android.webkit.WebStorage.QuotaUpdater) */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
