breautek opened a new pull request, #197: URL: https://github.com/apache/cordova-plugman/pull/197
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected CLI ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Modernizing the codebase to remove third-party dependencies ### Description <!-- Describe your changes in detail --> - Replaced p libs with native promises - Use async/await keywords and removed temporarily placed wrapper code - Added commands test spec with a mocked plugman (testing the actual plugman cordova-lib API is cordova-lib's job). Marked as a breaking change due to the introduction of async syntax. Current engines should be already a satisfied based on these new requirements. ### Testing <!-- Please describe in detail how you tested your changes. --> Ran npm test ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
