breautek opened a new pull request, #199: URL: https://github.com/apache/cordova-plugman/pull/199
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> `loud-rejection` was used to catch unhandledRejection, print to console and exit with an exit code of 1. This is no longer necessary to do manually as printing to console and exiting the process code with a code of `1` is now the default action in NodeJS since v15, which makes this module obsolete. Keeping it is just simply a supply chain attack vector for no benefit. ### Description <!-- Describe your changes in detail --> Removes the dependency and the usage of it. Note that this PR is built on top of https://github.com/apache/cordova-plugman/pull/198 so ideally that PR will be merged before this PR is merged -- which will also correct the commit count. ### Testing <!-- Please describe in detail how you tested your changes. --> npm test ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
