dpogue commented on code in PR #1643:
URL: https://github.com/apache/cordova-ios/pull/1643#discussion_r3440398257
##########
cordova-js-src/exec.js:
##########
@@ -143,7 +143,9 @@ function execProxy () {
}
execProxy.nativeFetchMessages = function () {
- return cordovaExec().nativeFetchMessages.apply(null, arguments);
+ if (cordovaExec().nativeFetchMessages) {
Review Comment:
So the implementation in this PR is the correct fix, to check if the WebView
JS bridge implements the method before calling it, so that `[commandQueue
fetchCommandsFromJs]` doesn't cause JS errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
