breautek commented on PR #1962:
URL: https://github.com/apache/cordova-android/pull/1962#issuecomment-4789733710
Yah I don't agree with reverting PR 1902.
> Enabling this on pre Android 15 would create an issue on Android 7 where
content is rendered behind the navigation bar, which should not happen, and
results in parts of the page not being visible.
I think this is just a safe area inset issue... when in operating in edge to
edge, the developer is going to have to be mindful of screen obstructions and
accommodate appropriately.
> But the guide says only that edge-to-edge is a requirement since Android
15 and that it can be anabled on older versions by
WindowCompat.enableEdgeToEdge(getWindow())
Android is going to enforce E2E mode on modern API levels and moving
forward. So extending on the previous comment. Cordova however makes opting
into E2E completely optional by recreating the old "system" bars such as the
status bar and positioning the webview as it would have on older API levels --
so while the app is technically operating in E2E fashion the webview itself
sits within the safe content area and users don't have to worry about
refactoring their app to handle safe area insets.
For users that DO opt into E2E mode, I would expect that would apply to all
API levels reasonably possible. That is unless if there is a strong reason
**not** support E2E on older devices, we should support it so that app
developers can get a consistent behaviour look and feel across API levels.
Natively, that is exactly what `WindowCompat.enableEdgeToEdge(getWindow())`
does.
E2E mode in the behavioural sense is not new ... ever since Android 5 (or 6,
whenever Android gave us more control over the status bar) I've been using an
"E2E" look 'n' feel by having the status bar an overlay on top of the webview,
and using insets to pad content appropriately. So I don't see any reason why we
couldn't support E2E mode for pre android 15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
