erisu commented on PR #1963: URL: https://github.com/apache/cordova-android/pull/1963#issuecomment-4829258035
Regards to comment: > Not sure if it could be considered breaking, pretty sure shouldOverrideUrlLoading and onReceivedError have no effect at the moment and introducing the non deprecated ones might change behaviors, but they are old behaviors that are not working at the moment. I am also not sure if this change should be considered breaking or a bug fix. The change could be seen as a fix for a regression, since functionality was effectively lost and this restores what would generally be considered the expected behavior. But also give that it has been 3 years since the change, maybe it could be breaking? There would be a behavior change. For example, if the application tries to load JavaScript files that don't exist, the following dialog will be displayed with the changes in this PR: <img width="320" height="713" alt="onReceivedError" src="https://github.com/user-attachments/assets/caffe8f5-e26b-466a-b6b9-916bf6580e8a"; /> The application will also close when you click OK. I vaguely remember this being the behavior previously. In the current release, for the past 3 years where this functionality was lost, the application silently ignores the failure but logs the following message to the console: ``` Failed to load resource: net::ERR_CONNECTION_REFUSED ``` Should we split the PR? One PR being the refactoring/cleanup work, and another could reintroduce `shouldOverrideUrlLoading` and `onReceivedError`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
