igorsantos07 commented on issue #1699: URL: https://github.com/apache/cordova-android/issues/1699#issuecomment-5086878305
Here is me, with similar issues two years and two API Levels later 🙃 With this upgrade, our icon is suddenly showing with a dark background when the device is in dark mode (but it doesn't go white when you switch dark mode off, not even after rebooting), and that's the exact color used by default in `values-night/cdv_colors.xml` (but which also seems to be the default Android "black"). The background color DOES change if you recompile the app, though, depending on the target's dark mode setting. Yikes?! ----------- On @globules-io's suggestions: we used the first (borrowing the splash bg) for the last two years, and it seems to have worked fine. At least I think. However, the second one doesn't seem to work that way. Trying something like ` <preference name="AndroidIconBackgroundColor" value="#FFFFFF" />` doesn't seem to create anything extra at `platforms/android/app/src/main/res/values/cdv_colors.xml` after `npx cordova build`, and there doesn't seem to be any `colors.xml` in my project folder, either. What did the trick this time was, well, reverting to the original instructions. Using a new `colors.xml` doesn't cause issues anymore, so it's safe to create such a file and use its color reference. Solves the issue for both dark/light modes. I guess this issue can be closed. And I guess the file conflict mentioned in the [other issue](https://github.com/apache/cordova-android/issues/1461#issuecomment-1407510749) got fixed as Cordova seems to be using `cdv_colors.xml` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
